Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate headers in OggStreamReader #85

Open
TonalidadeHidrica opened this issue Nov 7, 2020 · 1 comment · May be fixed by #94
Open

Encapsulate headers in OggStreamReader #85

TonalidadeHidrica opened this issue Nov 7, 2020 · 1 comment · May be fixed by #94

Comments

@TonalidadeHidrica
Copy link

Currently, three header fields in OggStreamReader, ident_hdr, comment_hdr and setup_hdr, are public fields. Although it is easy to access, these fields can be overwritten by the user of the parser and may lead to illegal state. These should be a private field and accessed through getter functions instead.

@est31
Copy link
Member

est31 commented Nov 7, 2020

It's a breaking change but I'm not objected to such breaking changes. Sounds like a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants