Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle allowing invalid package name chars #208

Closed
CasperWA opened this issue Nov 7, 2023 · 0 comments · Fixed by #224
Closed

Toggle allowing invalid package name chars #208

CasperWA opened this issue Nov 7, 2023 · 0 comments · Fixed by #224
Labels
enhancement New feature or request GH Workflows Issue/PR related to the callable workflows pre-commit hooks Issue/PR related to pre-commit hooks priority/medium Medium priority issue/PR

Comments

@CasperWA
Copy link
Collaborator

CasperWA commented Nov 7, 2023

While mostly not a desired thing, in some cases it would be good to be able to allow otherwise invalid characters for package names for the hooks and callable workflows that try to update the dependencies in a pyproject.toml file.

This issue was first reported in a cookiecutter template repository: EMMC-ASBL/oteapi-plugin-template#205, where the package name is a cookiecutter variable, i.e., of the type {{ cookiecutter.some_variable }}.

@CasperWA CasperWA added enhancement New feature or request pre-commit hooks Issue/PR related to pre-commit hooks GH Workflows Issue/PR related to the callable workflows priority/medium Medium priority issue/PR labels Nov 7, 2023
@CasperWA CasperWA linked a pull request Dec 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GH Workflows Issue/PR related to the callable workflows pre-commit hooks Issue/PR related to pre-commit hooks priority/medium Medium priority issue/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant