Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not always find configurations for application when using flavors #3

Open
btlogy opened this issue Jun 11, 2020 · 2 comments
Open

Comments

@btlogy
Copy link

btlogy commented Jun 11, 2020

I might have hit a bug/feature with this line:

If the project owner split google-services.json files in sub-directories per flavor, like this:

  • ./app/src/flavor1/google-services.json -> contains id for com.example.app.flavor1 only
  • ./app/src/flavor2/google-services.json -> contains id for com.example.app.flavor2 only

Fastlane action find_firebase_app_id called for 'com.example.app.flavor2' will parse only the first one and ends up with this message:
google-services.json file doesn't contain configurations for com.example.app.flavor2 application.

The obvious work-around is to make sure the first google-services.json file found in alphabetic order will at least hold the flavor id of the flavor you want to send to Firebase...

@btlogy
Copy link
Author

btlogy commented Jun 11, 2020

Of course, a better solution would be to parse all files rather than the first one only. And retain the first match for the package name requested.
But I'm sorry to say I'm not going to spend time to PR this kind of solution. :-/

@hamtiko
Copy link
Member

hamtiko commented Jul 27, 2020

@btlogy thanks for reporting.

Actually when you have more than one app in firebase you can use one google-service.json file for both apps as Firebase includes all android apps credentials in same file (only for Android).

I don't think that it is worth to support multiple file in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants