Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: minCharacters breaks search input #1718

Closed
ayastreb opened this issue May 31, 2017 · 3 comments · Fixed by #1722
Closed

Dropdown: minCharacters breaks search input #1718

ayastreb opened this issue May 31, 2017 · 3 comments · Fixed by #1722
Assignees
Labels

Comments

@ayastreb
Copy link
Contributor

I believe this issue is caused by #1690
When minCharacters is set to 1 (by default) - it is not possible to delete the last character in search query.
When minCharacters is set to > 1 - it is not possible to enter the search query at all.

Steps

  • Create a dropdown with default minCharacters
  • Create a dropdown with minCharacters = 2
  • Click on dropdown and start typing search query (e.g. -> "Afgan")
  • Now you want to change your search query to "USA", so delete first query and start typing "USA"

Expected Result

  • It should be possible to type in and change search query

Actual Result

  • when minCharacters is set to 1 (by default) it is not possible to delete the last character, it always remains in the input
  • when minCharacters is set to > 1 it is not possible to enter the search query at all

Version

0.68.4

Testcase

https://codepen.io/anon/pen/PmMPMN

@dyesseyumba would you like to check this?

@layershifter
Copy link
Member

@ayastreb Thanks for the excellent report 👍

I will take a look on this, seems we need more tests there after the fix.

@layershifter
Copy link
Member

I've made a some investigation there, as I see #1690 doesn't implemented minCharacters feature correctly. How it works in SUI (minCharacters 3):

Without input

peek 2017-05-31 12-37

Two characters

peek 2017-05-31 12-44

There characters

peek 2017-05-31 12-46

@krunal222
Copy link

krunal222 commented Nov 2, 2017

try for it.

fullTextSearch : true,     // default : false
minCharacters : 3        // default : 0

i hope Solve for your problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants