New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed: add shorthand for iframe #1804

Closed

Rickco17 opened this issue Jun 28, 2017 · 1 comment

Labels

Rickco17 commented Jun 28, 2017

✔ BUGS → This form is required:
When embedding a youtube video the fullscreen option is disabled. This should be a property for the Embed component.

layershifter added the enhancement label

Member

layershifter commented Jun 28, 2017

Makes sense to me, I think we can refactor the iframe to child component and then use power of shorthands.

layershifter added help wanted and removed help wanted labels

layershifter mentioned this issue

feat(Embed): add iframe shorthand #1810

Merged

layershifter changed the title ~~Embed component fullscreen option~~ Embed: add shorthand for iframe

levithomason closed this as completed in #1810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment