Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ButtonExampleLabeledIcon): buttons aren't labeled #2190

Closed
levithomason opened this issue Oct 12, 2017 · 1 comment
Closed

docs(ButtonExampleLabeledIcon): buttons aren't labeled #2190

levithomason opened this issue Oct 12, 2017 · 1 comment
Labels
docs

Comments

@levithomason
Copy link
Member

levithomason commented Oct 12, 2017 •
edited
Loading

Steps to Reproduce

  1. Open the link in the testcase.

Expected
The Buttons should each be labeled icon buttons.

Result
The Buttons have an icon, but aren't labeled. They should also be vertical as inline labeled icon buttons do not look good.

Testcase
https://react.semantic-ui.com/elements/button#button-example-labeled-icon

SUIR

image

SUI Core

image

The Fix

The Button.Group in the example should be updated to include vertical labeled icon props.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@levithomason @patrikmolsson @layershifter