From 386086ba6413cf475771e9aa61f5bea9431944af Mon Sep 17 00:00:00 2001 From: Brendan Jurd Date: Sat, 14 Oct 2017 13:00:08 +1100 Subject: [PATCH 1/2] Fix spelling/grammar errors. Mostly its/it's errors in this commit, along with a few verb number errors. --- .../elements/List/Variations/ListExampleCelled.js | 2 +- docs/app/Layouts/HomepageLayout.js | 2 +- src/addons/Ref/Ref.js | 2 +- src/elements/Divider/Divider.d.ts | 2 +- src/elements/Divider/Divider.js | 2 +- src/elements/Input/Input.d.ts | 2 +- src/elements/Input/Input.js | 2 +- src/modules/Accordion/Accordion.d.ts | 2 +- src/modules/Accordion/Accordion.js | 2 +- src/modules/Popup/Popup.d.ts | 2 +- test/specs/modules/Dropdown/Dropdown-test.js | 4 ++-- test/specs/modules/Rating/Rating-test.js | 14 +++++++------- 12 files changed, 19 insertions(+), 19 deletions(-) diff --git a/docs/app/Examples/elements/List/Variations/ListExampleCelled.js b/docs/app/Examples/elements/List/Variations/ListExampleCelled.js index ff0c69baa2..133108efd1 100644 --- a/docs/app/Examples/elements/List/Variations/ListExampleCelled.js +++ b/docs/app/Examples/elements/List/Variations/ListExampleCelled.js @@ -14,7 +14,7 @@ const ListExampleCelled = () => ( Poodle - A poodle, its pretty basic + A poodle, it's pretty basic diff --git a/docs/app/Layouts/HomepageLayout.js b/docs/app/Layouts/HomepageLayout.js index 8b3ef118f8..15ba257d79 100644 --- a/docs/app/Layouts/HomepageLayout.js +++ b/docs/app/Layouts/HomepageLayout.js @@ -160,7 +160,7 @@ export default class HomepageLayout extends Component {
Did We Tell You About Our Bananas?

- Yes I know you probably disregarded the earlier boasts as non-sequitur filler content, but its really + Yes I know you probably disregarded the earlier boasts as non-sequitur filler content, but it's really true. It took years of gene splicing and combinatory DNA research, but our bananas can really dance.

diff --git a/src/addons/Ref/Ref.js b/src/addons/Ref/Ref.js index ee8683f177..5a698d74d5 100644 --- a/src/addons/Ref/Ref.js +++ b/src/addons/Ref/Ref.js @@ -29,7 +29,7 @@ export default class Ref extends Component { componentDidMount() { const { innerRef } = this.props - // Heads up! Don't move this condition, it's a short circle that avoids run of `findDOMNode` + // Heads up! Don't move this condition, it's a short circuit that avoids run of `findDOMNode` // if `innerRef` isn't passed // eslint-disable-next-line react/no-find-dom-node if (innerRef) innerRef(findDOMNode(this)) diff --git a/src/elements/Divider/Divider.d.ts b/src/elements/Divider/Divider.d.ts index 007d9ff8e9..54af60d6ec 100644 --- a/src/elements/Divider/Divider.d.ts +++ b/src/elements/Divider/Divider.d.ts @@ -24,7 +24,7 @@ export interface DividerProps { /** Divider can segment content horizontally. */ horizontal?: boolean; - /** Divider can have it's colours inverted. */ + /** Divider can have its colours inverted. */ inverted?: boolean; /** Divider can provide greater margins to divide sections of content. */ diff --git a/src/elements/Divider/Divider.js b/src/elements/Divider/Divider.js index c087151472..1b970f9b8d 100644 --- a/src/elements/Divider/Divider.js +++ b/src/elements/Divider/Divider.js @@ -71,7 +71,7 @@ Divider.propTypes = { /** Divider can segment content horizontally. */ horizontal: PropTypes.bool, - /** Divider can have it's colours inverted. */ + /** Divider can have its colours inverted. */ inverted: PropTypes.bool, /** Divider can provide greater margins to divide sections of content. */ diff --git a/src/elements/Input/Input.d.ts b/src/elements/Input/Input.d.ts index b4dbe9bebc..ca3c5679d1 100644 --- a/src/elements/Input/Input.d.ts +++ b/src/elements/Input/Input.d.ts @@ -31,7 +31,7 @@ export interface InputProps { /** An Input field can show the data contains errors. */ error?: boolean; - /** Take on the size of it's container. */ + /** Take on the size of its container. */ fluid?: boolean; /** An Input field can show a user is currently interacting with it. */ diff --git a/src/elements/Input/Input.js b/src/elements/Input/Input.js index c69269915f..17f2f2069a 100644 --- a/src/elements/Input/Input.js +++ b/src/elements/Input/Input.js @@ -53,7 +53,7 @@ class Input extends Component { /** An Input field can show the data contains errors. */ error: PropTypes.bool, - /** Take on the size of it's container. */ + /** Take on the size of its container. */ fluid: PropTypes.bool, /** An Input field can show a user is currently interacting with it. */ diff --git a/src/modules/Accordion/Accordion.d.ts b/src/modules/Accordion/Accordion.d.ts index 23c29b748f..fbe086611f 100644 --- a/src/modules/Accordion/Accordion.d.ts +++ b/src/modules/Accordion/Accordion.d.ts @@ -10,7 +10,7 @@ export interface AccordionProps extends AccordionAccordionProps { /** Additional classes. */ className?: string; - /** Format to take up the width of it's container. */ + /** Format to take up the width of its container. */ fluid?: boolean; /** Format for dark backgrounds. */ diff --git a/src/modules/Accordion/Accordion.js b/src/modules/Accordion/Accordion.js index 8aca1a4d1a..dd0e7876a7 100644 --- a/src/modules/Accordion/Accordion.js +++ b/src/modules/Accordion/Accordion.js @@ -43,7 +43,7 @@ Accordion.propTypes = { /** Additional classes. */ className: PropTypes.string, - /** Format to take up the width of it's container. */ + /** Format to take up the width of its container. */ fluid: PropTypes.bool, /** Format for dark backgrounds. */ diff --git a/src/modules/Popup/Popup.d.ts b/src/modules/Popup/Popup.d.ts index d582dcaae9..b764edc608 100644 --- a/src/modules/Popup/Popup.d.ts +++ b/src/modules/Popup/Popup.d.ts @@ -23,7 +23,7 @@ export interface PopupProps extends PortalProps { /** Simple text content for the popover. */ content?: SemanticShorthandItem; - /** A Flowing popup have no maximum width and continue to flow to fit its content. */ + /** A flowing Popup has no maximum width and continues to flow to fit its content. */ flowing?: boolean; /** Header displayed above the content in bold. */ diff --git a/test/specs/modules/Dropdown/Dropdown-test.js b/test/specs/modules/Dropdown/Dropdown-test.js index 1ba2b31a47..2608c79803 100644 --- a/test/specs/modules/Dropdown/Dropdown-test.js +++ b/test/specs/modules/Dropdown/Dropdown-test.js @@ -561,7 +561,7 @@ describe('Dropdown', () => { .should.not.have.descendants('.selected') }) it('is set when clicking an item', () => { - // random item, skip the first as its selected by default + // random item, skip the first as it's selected by default const randomIndex = 1 + _.random(options.length - 2) wrapperMount() @@ -575,7 +575,7 @@ describe('Dropdown', () => { .should.have.prop('selected', true) }) it('is ignored when clicking a disabled item', () => { - // random item, skip the first as its selected by default + // random item, skip the first as it's selected by default const randomIndex = 1 + _.random(options.length - 2) options[randomIndex].disabled = true diff --git a/test/specs/modules/Rating/Rating-test.js b/test/specs/modules/Rating/Rating-test.js index 995f8e5eab..0f2fdee8c3 100644 --- a/test/specs/modules/Rating/Rating-test.js +++ b/test/specs/modules/Rating/Rating-test.js @@ -97,7 +97,7 @@ describe('Rating', () => { .should.not.have.className('selected') wrapper .find('RatingIcon[selected=true]') - .should.have.length(0, 'Some RatingIcons did not remove its "selected" prop') + .should.have.length(0, 'Some RatingIcons did not remove their "selected" prop') }) }) @@ -139,7 +139,7 @@ describe('Rating', () => { wrapper .find('RatingIcon[selected=true]') - .should.have.length(0, 'Some RatingIcons did not remove its "selected" prop') + .should.have.length(0, 'Some RatingIcons did not remove their "selected" prop') }) }) @@ -153,7 +153,7 @@ describe('Rating', () => { .simulate('click') wrapper .find('RatingIcon[active=true]') - .should.have.length(5, 'Some RatingIcons did not retain its "active" prop') + .should.have.length(5, 'Some RatingIcons did not retain their "active" prop') }) it('allows toggling when set to "auto" with a single icon', () => { @@ -200,7 +200,7 @@ describe('Rating', () => { .simulate('click') wrapper .find('RatingIcon[active=true]') - .should.have.length(0, 'Some RatingIcons did not remove its "active" prop') + .should.have.length(0, 'Some RatingIcons did not remove their "active" prop') }) it('prevents clearing when false with a single icon', () => { @@ -220,7 +220,7 @@ describe('Rating', () => { .simulate('click') wrapper .find('RatingIcon[active=true]') - .should.have.length(5, 'Some RatingIcons did not retain its "active" prop') + .should.have.length(5, 'Some RatingIcons did not retain their "active" prop') }) }) @@ -248,7 +248,7 @@ describe('Rating', () => { .simulate('click') wrapper .find('RatingIcon[active=true]') - .should.have.length(3, 'Some RatingIcons lost its "active" prop') + .should.have.length(3, 'Some RatingIcons lost their "active" prop') }) it('prevents icons from becoming selected on mouse enter', () => { @@ -278,7 +278,7 @@ describe('Rating', () => { wrapper.simulate('mouseLeave') wrapper .find('RatingIcon[selected=true]') - .should.have.length(3, 'Some RatingIcons lost its "selected" prop') + .should.have.length(3, 'Some RatingIcons lost their "selected" prop') }) it('prevents icons from becoming active on click', () => { From 1e9a48b241f89accb7c8974edb6bb525a935254a Mon Sep 17 00:00:00 2001 From: Brendan Jurd Date: Sat, 14 Oct 2017 13:05:58 +1100 Subject: [PATCH 2/2] Fix from/form typo. --- src/lib/customPropTypes.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/customPropTypes.js b/src/lib/customPropTypes.js index 1e12d14864..12ff5665ea 100644 --- a/src/lib/customPropTypes.js +++ b/src/lib/customPropTypes.js @@ -71,7 +71,7 @@ export const suggest = suggestions => (props, propName, componentName) => { } /** - * Disallow other props form being defined with this prop. + * Disallow other props from being defined with this prop. * @param {string[]} disallowedProps An array of props that cannot be used with this prop. */ export const disallow = disallowedProps => (props, propName, componentName) => {