[BUG] Collection of small bugs

[SethCram]

Describe the bug

• Collection of small bugs

Desktop (please complete the following information):

• OS: Windows
• Game Version: 0.6.0

Development

• jason player throwing null references when counselors dmg one another

  • Log file:
    (Filename: C:/Users/crazy/source/repos/Friday-the-13th-Game/Friday the 13th Game/Assets/Scripts/Stats/CharacterStats.cs Line: 174)

  • NullReferenceException: Object reference not set to an instance of an object
    at CharacterStats.CallHealthSlider (System.Int32 maxHP, System.Int32 currHP) [0x00001] in C:\Users\crazy\source\repos\Friday-the-13th-Game\Friday the 13th Game\Assets\Scripts\Stats\CharacterStats.cs:120
    at (wrapper delegate-invoke) System.Action`2[System.Int32,System.Int32].invoke_void_T1_T2(int,int)
    at CharacterStats.RPC_TakeDamage (System.Int32 dmgDealt) [0x00099] in C:\Users\crazy\source\repos\Friday-the-13th-Game\Friday the 13th Game\Assets\Scripts\Stats\CharacterStats.cs:263
    at (wrapper managed-to-native) System.Reflection.MonoMethod.InternalInvoke(System.Reflection.MonoMethod,object,object[],System.Exception&)
    at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00032] in <2b3a3162be434770b7a4fac8b896e90c>:0
    Rethrow as TargetInvocationException: Exception has been thrown by the target of an invocation.
    at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0004b] in <2b3a3162be434770b7a4fac8b896e90c>:0
    at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in <2b3a3162be434770b7a4fac8b896e90c>:0
    at Photon.Pun.PhotonNetwork.ExecuteRpc (ExitGames.Client.Photon.Hashtable rpcData, Photon.Realtime.Player sender) [0x005b6] in C:\Users\crazy\source\repos\Friday-the-13th-Game\Friday the 13th Game\Assets\Photon\PhotonUnityNetworking\Code\PhotonNetworkPart.cs:553
    at Photon.Pun.PhotonNetwork.OnEvent (ExitGames.Client.Photon.EventData photonEvent) [0x000a4] in C:\Users\crazy\source\repos\Friday-the-13th-Game\Friday the 13th Game\Assets\Photon\PhotonUnityNetworking\Code\PhotonNetworkPart.cs:2201
    at Photon.Realtime.LoadBalancingClient.OnEvent (ExitGames.Client.Photon.EventData photonEvent) [0x0052e] in C:\Users\crazy\source\repos\Friday-the-13th-Game\Friday the 13th Game\Assets\Photon\PhotonRealtime\Code\LoadBalancingClient.cs:3353
    at ExitGames.Client.Photon.PeerBase.DeserializeMessageAndCallback (ExitGames.Client.Photon.StreamBuffer stream) [0x002ea] in <4c05f01c27d1415bafcda4c1ab7160e0>:0
    at ExitGames.Client.Photon.EnetPeer.DispatchIncomingCommands () [0x003ca] in <4c05f01c27d1415bafcda4c1ab7160e0>:0
    at ExitGames.Client.Photon.PhotonPeer.DispatchIncomingCommands () [0x00038] in <4c05f01c27d1415bafcda4c1ab7160e0>:0
    at Photon.Pun.PhotonHandler.Dispatch () [0x00030] in C:\Users\crazy\source\repos\Friday-the-13th-Game\Friday the 13th Game\Assets\Photon\PhotonUnityNetworking\Code\PhotonHandler.cs:222
    Rethrow as AggregateException: Caught 1 exception(s) in methods called by DispatchIncomingCommands(). Rethrowing first only (see above).
    at Photon.Pun.PhotonHandler.Dispatch () [0x00097] in C:\Users\crazy\source\repos\Friday-the-13th-Game\Friday the 13th Game\Assets\Photon\PhotonUnityNetworking\Code\PhotonHandler.cs:240
    at Photon.Pun.PhotonHandler.FixedUpdate () [0x00012] in C:\Users\crazy\source\repos\Friday-the-13th-Game\Friday the 13th Game\Assets\Photon\PhotonUnityNetworking\Code\PhotonHandler.cs:145

  • caused bc of trying to update HP slider when not our player being hurt

• pair of numbers spawned twice everytime counselor hits counselor

  • everyone besides the inflictor calls the number spawn method
  • so didnt spawn numbers unless our photon view

• error thrown on non master client w/ done button pressed on Stats UI

  • just says starting coroutine and logging an assertion
  • not sure why log msgs so lengthy here
  • needs verification
    • ...

• null ref thrown w/ instances left game lobby

  • usually only w/ someone within interaction radius of item
  • needs verification
    • ...

• error thrown regarding step offset

  • occurred in game lobby w/ player died midair
  • verify that it occurs only when player dies midair
    • it does not
    • happened during normal die on solid ground
  • "Step Offset must be less or equal to + * 2"
    • "ThirdPersonMovement:GroundedReset () (at Assets/Scripts/Player Files/ThirdPersonMovement.cs:170)"
    • "ThirdPersonMovement:Update () (at Assets/Scripts/Player Files/ThirdPersonMovement.cs:133)"
  • Also, warning thrown:
    • "CharacterController.Move called on inactive controller"
      • "ThirdPersonMovement:Update () (at Assets/Scripts/Player Files/ThirdPersonMovement.cs:151)"
  • player gets stuck in midair
  • not sir when happens and doesnt happen

[SethCram]

gated updating of hp slider

[SethCram]

gate number spawning method + documentation