Tests in PHP 7

[boenrobot]

With
93adc40

There is now no testing of any sort of compatibility with PHP 7, which is a bit unfortunate. Granted it was just a lint check before, rather than PHPUnit test before, but still, it was something.

In the project I work on, we're currently using PHP 7.4, but we came to zf1-future after migrating from PHP 7.1 (the last version where the original ZF1 works) to PHP 7.4. The fact that zf1-future works with PHP 7.1 was invaluable in the migration. It allowed us to switch to it before migrating the rest of the code, and having the confidence that any errors encountered in the new PHP version are not ZF1's fault.

We're currently in the process of pulling the same in a jump between PHP 7.4 and PHP 8.1 (can't wait for a tagged release with the latest changes btw... last time we tried, we had an issue that I think c098449 will solve), but even though we have mostly crossed that bridge already, I am sure others have not. I think compatibility with PHP 7 on a CI level should be restored, or incompatibilities with those older versions are sure to arise sooner or later.

[fredericgboutin-yapla]

My 2 cents: pivot and use https://github.com/zf1s/zf1 instead.

Much more respectful towards avoiding regressions and supporting earlier PHP versions. Their CI/CD runs tests and lint for PHP 5.3 up to 8.2. It's really just a drop-in replacement,

composer require zf1s/zf1

[Jimbolino]

Much more respectful towards avoiding regressions and supporting earlier PHP versions. Their CI/CD runs tests and lint for PHP 5.3 up to 8.2. It's really just a drop-in replacement,

zf1s currently does not support 8.2 yet, all their tests are failing.
At the time of php 8.1 and 8.2 release they were still working on supporting the previous version.

My 2 cents:

• if you require only 7.1 stick with the original zf1.
• if you need 7.4-8.1 support zf1-future and zf1s are both fine
• do you need 8.2 and newer, zf1-future is the way to go

[croensch]

The question is if 1.23.0 will remove support for PHP 7.x as it is not tested anymore?
Then 4bd8f78 (including c098449) could still be released as 1.22.1.

[Jimbolino]

I've run the tests on 7.3 and 7.4, and the only failing tests are related to Zend_Filter_Encrypt_Openssl
and these tests are disabled on 8.0+ anyway
https://github.com/Jimbolino/zf1-future/actions/runs/4642611000/jobs/8216658235#step:10:262
https://github.com/Jimbolino/zf1-future/actions/runs/4642611000/jobs/8216658287#step:10:259

[boenrobot]

I managed to find some time to address this myself.

See #353

[develart-projects]

I'll look into this soon, possibly solving the problem on next release.

[develart-projects]

Merged and scheduled for 1.23.0