Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support carthage #42

Open
eggswift opened this issue Sep 24, 2016 · 7 comments
Open

Support carthage #42

eggswift opened this issue Sep 24, 2016 · 7 comments

Comments

@eggswift
Copy link

Please support carthage.

@pwlkania
Copy link

@pwlkania
Copy link

In Swift:
import iOSSystemServices

@Shmoopi
Copy link
Owner

Shmoopi commented Sep 28, 2017

Hello @pwlkania

Can you update the Pull Request to support the latest version?

@pwlkania
Copy link

@Shmoopi
Pull request updated. Please check this out.

@Shmoopi
Copy link
Owner

Shmoopi commented Sep 29, 2017

Hi @pwlkania

There are some issues with the latest pull request.

SSNetworkInfo removed the reference to net/route.h due to a compile error on devices. In addition, I don't see any support for Carthage in the request. I only see updates to the demo application workspace, a header file, and a plist.

Can you double check?

@pwlkania
Copy link

Hej @Shmoopi

Have you encountered any difficulties?

I've just integrated test project with current version of my branch via Carthage and works perfectly.

Here's my Cartfile:
github "pwlkania/iOS-System-Services" "carthage"

@pwlkania
Copy link

Hi @Shmoopi

I reversed SSNetworkInfo to your version. My change was for Xcode 8.x.x as far I remember, but it didn't work for Xcode 9 indeed. Now it should work (tested on Xcode 9.1 (9B55))

Please check this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants