Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Animations] Enable scroll animation on Policy pages #2576

Open
kjellr opened this issue Apr 26, 2023 · 0 comments
Open

[Animations] Enable scroll animation on Policy pages #2576

kjellr opened this issue Apr 26, 2023 · 0 comments
Labels
Category: Enhancement New feature or request 🎨 Design: Animations Bugs, features or enhancements related to animations

Comments

@kjellr
Copy link
Contributor

kjellr commented Apr 26, 2023

Policy pages should animate in the same way that Post/Page templates will as a result of the work being done in #2381.

These templates aren't defined in the theme, but instead flow content into theme.liquid. They do however use a consistent set of two classes to house the content: shopify-policy__title and shopify-policy__body. We might be able to target those classes manually to apply our animation.

Today:

today.mp4

Intended:

intended.mp4
@kjellr kjellr added Category: Enhancement New feature or request motion labels Apr 26, 2023
@kjellr kjellr mentioned this issue Apr 27, 2023
Merged
8 tasks
@kimberlyoleiro kimberlyoleiro added 🎨 Design: Animations Bugs, features or enhancements related to animations and removed motion labels May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Enhancement New feature or request 🎨 Design: Animations Bugs, features or enhancements related to animations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kjellr @kimberlyoleiro