Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image banner - add settings #890

Closed
KaichenWang opened this issue Nov 15, 2021 · 2 comments · Fixed by #900
Closed

Image banner - add settings #890

KaichenWang opened this issue Nov 15, 2021 · 2 comments · Fixed by #900
Assignees
@KaichenWang @sofiamatulis @wiktoriaswiecicka-zz
Labels
Category: Enhancement New feature or request

Comments

@KaichenWang
Copy link
Contributor

Describe the enhancement you'd like
Add the following section level settings to Image Banner:

  • Text alignment
  • Desktop text position

Describe alternatives you've considered
n/a

Additional context/screenshots
Screen Shot 2021-11-15 at 3 13 21 PM
@KaichenWang KaichenWang added the Category: Enhancement New feature or request label Nov 15, 2021
@KaichenWang KaichenWang mentioned this issue Nov 17, 2021
Merged
5 tasks
@sofiamatulis sofiamatulis self-assigned this Nov 18, 2021
@KaichenWang
Copy link
Contributor Author

https://www.figma.com/file/JcYdswrk2JhqBTGBVWPM7J/Dawn-2.0?node-id=12908%3A66318

@melissaperreault
Copy link
Contributor

melissaperreault commented Nov 19, 2021 •
edited
Loading

👋 Just passing by to make sure we'll request merchant-facing documentation update to reflect this enhancement before it goes live! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaichenWang KaichenWang

@sofiamatulis sofiamatulis

@wiktoriaswiecicka-zz wiktoriaswiecicka-zz

Labels
Category: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add image banner settings Shopify/dawn
4 participants
@KaichenWang @sofiamatulis @melissaperreault @wiktoriaswiecicka-zz