Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z.Spe.EnableLanguageFallbackTest.config appears in 6.1 packages #1189

Closed
michaellwest opened this issue May 7, 2020 · 4 comments
Closed
Assignees
Labels
bug Oops! Sorry for the inconvenience.
Projects
Milestone

Comments

@michaellwest
Copy link
Member

Turns out that while testing out the EnableLanguage Fallback feature in #1162 I managed to leave the configuration for testing. Oops.

Need to build new packages for this to be removed.

@michaellwest michaellwest self-assigned this May 7, 2020
@michaellwest
Copy link
Member Author

Recommendation is to remove the file /App_Config/Include/z-Spe/z.Spe.EnableLanguageFallbackTest.config.

@michaellwest michaellwest added the bug Oops! Sorry for the inconvenience. label May 7, 2020
@michaellwest michaellwest added this to the 6.1 milestone May 7, 2020
@michaellwest
Copy link
Member Author

I suppose the consequence of this would be that you have fallback enabled on the shell and website sites.

Performance for this alone appears to make certain APIs slower. I suspect new item creation.

@michaellwest
Copy link
Member Author

michaellwest commented May 7, 2020

Here's an example of the performance difference it makes when running some unit tests for SXA.

New-Tenant Unit Tests => Create tenant with all default settings

Version Time
6.0 33.89s
6.1 w/ config 50.14s
6.1 w/o config 32.23s
6.1 w/ 9d695c6 7.74s

New-Site Unit Tests => Create site with all default settings

Version Time
6.1 108.15s
6.1 w/ 9d695c6 53.8s

@michaellwest
Copy link
Member Author

Old vs New

image

@michaellwest michaellwest added this to Done in Mr. Fixit May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Oops! Sorry for the inconvenience.
Projects
No open projects
Mr. Fixit
  
Done
Development

No branches or pull requests

1 participant