Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validations for User APIs #4

Open
navinpai opened this issue Oct 1, 2022 · 0 comments
Open

Validations for User APIs #4

navinpai opened this issue Oct 1, 2022 · 0 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@navinpai
Copy link
Member

navinpai commented Oct 1, 2022

User APIs have very limited validations in place, primarily targeted to the surface area of SlashGo extension. However, we need to add more validations around these APIs to handle invalid API payloads. Some examples include:

  • Required fields to be provided when creating a new user
  • Edit API should not allow user to edit non-admin user from editing any user other than themselves
  • Admin should be able to edit any non-admin user in their own org.
  • Edit API should not allow setting of any required field to null

Some of these are identified by TODO in the controller. Ideally, would be nice if this could be done alongside #2 to ensure we write tests for the new validations as well.

@navinpai navinpai added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 1, 2022
@iarchanarajkumar iarchanarajkumar self-assigned this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants