Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent crash in MinimizeGroupCost - Out of Bounds #5

Open
hytel opened this issue Mar 14, 2023 · 0 comments
Open

Consistent crash in MinimizeGroupCost - Out of Bounds #5

hytel opened this issue Mar 14, 2023 · 0 comments

Comments

@hytel
Copy link

hytel commented Mar 14, 2023

In the MinimizeGroupCost method, there is a loop on v, and inside that a loop on fr. Looks like fr indicates in part how many items have been processed and removed from the gid_track list. It's very confusing and uncommented code. It looks like elements are being removed from "gid_track" and added to "track". The problem is that there is a "gid_track[0].pop_back()" to remove the last item. But right after that, a check is made against the last element at (tSize - 1 - fr). But, this element position was just removed. What exactly is the intent of this loop on "fr" inside a loop on "v" ?

It looks like you fixed this in a previous issue, but brought it back more recently in an optimization check-in. Was this a mistake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant