Why is the newtonsoft.json.dll modified?

[jobrien78]

Prerequisites

• Verify that this is not a Windows issue;
• Refer to the System requirements;
• I do not use a homebrew Windows image;
• I did not tweak Windows before that could cause system instability;
• Attach a created log. You may find it in the Logs folder.

Steps To Reproduce

Hi, I had a look at the dlls and in particular newtonsoft.json.dll which comes packed with the app and am finding its hash doesnt match the one that is supposedly have been downloaded from the official JamesNK/Newtonsoft.Json repo during the build process (

SophiApp/SophiApp/Scripts/Get-BinaryFiles.ps1

Lines 84 to 87 in f0e2c94

	Uri = "https://api.github.com/repos/JamesNK/Newtonsoft.Json/releases/latest"
	UseBasicParsing = $true
	}
	$NewtonsoftJsonLatestVersion = ((Invoke-RestMethod @Parameters).assets | Where-Object -FilterScript {$_.browser_download_url -match "Json"}).browser_download_url

)

Can you explain why the dll is modified?

Also why isn't this dll at least be downloaded via NuGet?

Expected behavior

N/A

Actual behaviour

N/A

Windows Version

Win 10

SophiApp version

Current

SophiApp release type

SophiApp

Logs

N/A

[farag2]

Hm... I/we do not modify any of DLLs. Everything is automated. Let me check...

[farag2]

Yeah, they're really not equal. But how?.. O_O

[farag2]

All that I understood is that DLL in the SophiApp folder is equal to the Nuget one, but not equal to the GitHub one at the same time. Also the GitHub dll isn't equal to the Nuget dll. They even have different timestamp.

[jobrien78]

I haven't tried the one from NuGet, but running your get binary script I am also able to get the expected hash which should be in the SophiApp.

[farag2]

I will ask my colleague tomorrow, how it could happen when we download one dll but get another after compilation. I'm really puzzled.

[jobrien78]

OK, thank you.

[farag2]

Fixed with #131