Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sovereign SDK should work with stable rust #29

Closed
bkolad opened this issue Feb 6, 2023 · 3 comments · Fixed by #605, #606 or #869
Closed

Sovereign SDK should work with stable rust #29

bkolad opened this issue Feb 6, 2023 · 3 comments · Fixed by #605, #606 or #869
Assignees
Labels
enhancement New feature or request

Comments

@bkolad
Copy link
Member

bkolad commented Feb 6, 2023

Overview
Currently, we use nightly because we need an associated type default in the Module trait.
Once we have macro for deriving the Module trait automatically we will be able to move to stable rust.

Acceptance Criteria
Add a stable build to CI. Build passes.

@bkolad bkolad added the enhancement New feature or request label Feb 6, 2023
@preston-evans98
Copy link
Member

Moving to stable will make our CI build caching (#88) much more effective. You can't re-use dependency builds across compiler versions, and nightly updates every night - so our cache is effectively wiped every morning.

@citizen-stig
Copy link
Member

As for today, I've checked what unstable features we use:

▸ grep -rh --exclude-dir=target '^#\!\[feature' .
#![feature(log_syntax)]
#![feature(associated_type_defaults)]
#![feature(array_windows)]
#![feature(array_chunks)]
  1. associated_type_defaults Tracking issue for RFC 2532, "Associated type defaults" rust-lang/rust#29661
  2. log_syntax Tracking issue for log_syntax, trace_macros rust-lang/rust#29598
  3. array_windows Tracking Issue for slice::array_windows rust-lang/rust#75027
  4. array_chunks Tracking Issue for slice::array_chunks rust-lang/rust#74985

So switching to stable rust will be possible only after these features are stabilitzed.

@citizen-stig
Copy link
Member

Fixed by @preston-evans98 in #869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment