New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intrinsicContentSize does not behave like UIPageControl #22

Open

hpique opened this issue Mar 11, 2014 · 1 comment

hpique commented Mar 11, 2014

Thanks for open sourcing this component.

I noticed that SMPageControl intrinsicContentSize does not behave like UIPageControl.

In particular, it returns UIViewNoIntrinsicMetric for the width whereas UIPageControl calculates a width based on the number of pages.

Without this, SMPageControl is not a drop in replacement for UIPageControl.

The text was updated successfully, but these errors were encountered:

bejo commented Oct 6, 2014

I just fixed it in my fork: #29

Please let me know if it works fine for you. (it does for me, but... this fix seems like was almost too easy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment