Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts (both desktop and start) are not created on some computers. #509

Open
molster opened this issue Dec 1, 2015 · 14 comments
Open

Comments

@molster
Copy link

molster commented Dec 1, 2015

So we have tested this on well over 20 computers (Windows 7, 8, 8.1, and 10), and it seems to work fine on all our test comps. However at least 10 reports from users say after they install it (ranging from any of the windows version said above), they have no idea where to find the app.

Turns out, it was creating no shortcuts for them of any kind. What would prevent Squirrel from making shortcuts for a user?

@anaisbetts
Copy link
Contributor

Antivirus often will mess with setup and prevent hooks from running - are you signing your executable?

@molster
Copy link
Author

molster commented Dec 1, 2015

yeah, we are signing both of the exes in our project.
Honestly antivirus did not enter my mind, figured if it allows for the install, it wouldn't be preventing the shortcuts.

If an antivirus is blocking the hooks for shortcuts, would this not show up on their Squirrel install logs?

@anaisbetts
Copy link
Contributor

@molster It might, AV does all manner of hacky random things. Look for "Unauthorized Access"

@molster
Copy link
Author

molster commented Dec 7, 2015

alright, was able to get a user with a log, i'm seeing

2015-12-06 22:06:34> ApplyReleasesImpl: Squirrel Enabled Apps: [C:\Users\Administrator\AppData\Local\Innkeeper\app-0.1.11\Innkeeper.exe]
2015-12-06 22:06:50> ApplyReleasesImpl: Couldn't run Squirrel hook, continuing: C:\Users\Administrator\AppData\Local\Innkeeper\app-0.1.11\Innkeeper.exe: System.OperationCanceledException: The operation was canceled.
at System.Threading.CancellationToken.ThrowOperationCanceledException()
at Squirrel.Utility.<>c__DisplayClassf.<InvokeProcessAsync>b__e()
at System.Threading.Tasks.Task.InnerInvoke()
at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Squirrel.Utility.<InvokeProcessAsync>d__11.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClassdd.<<invokePostInstall>b__d1>d__df.MoveNext()
2015-12-06 22:06:51> ApplyReleasesImpl: Starting fixPinnedExecutables
2015-12-06 22:06:51> ApplyReleasesImpl: fixPinnedExecutables: oldAppDirectories is empty, this is pointless
2015-12-06 22:06:51> ApplyReleasesImpl: Fixing up tray icons

would this fall in line with just an AV issue?
if so, will be fun to figure out how to work around it.

@anaisbetts
Copy link
Contributor

This means that your application didn't return in time or crashed or generally did something silly. Try running the hook yourself by-hand and see if it works (i.e. just run Innkeeper --squirrel-updated a.new.version.number)

@molster
Copy link
Author

molster commented Dec 7, 2015

Thanks for the reply,

The above does not happen on any of our test comps, so ill have the user give it a try if I can get a hold of him. Thanks!

@Jaykah
Copy link

Jaykah commented Jan 5, 2016

I was able to reproduce this issue on three different Win10 machines. Any possible fixes?

@molster
Copy link
Author

molster commented Jan 5, 2016

Jaykah, does your error log look similar to mine?
Also what results do you get from what paulcbetts suggests? I wasn't able to get a user on my project to get back to me

@Jaykah
Copy link

Jaykah commented Jan 6, 2016

@molster yesm the same error message (Couldn't run Squirrel hook, continuing). Running appname --squirrel-updated a.new.version.number did not help.

@AkioUnity
Copy link

I have same issue.

Shortcuts (both desktop and start) are not created

2018-04-07 09:58:42> ApplyReleasesImpl: Couldn't run Squirrel hook, continuing:

@Thieum
Copy link
Contributor

Thieum commented May 6, 2019

@molster @Jaykah @AkioUnity is it an issue you are still experiencing with the latest version of Squirrel?

@zdQAQ
Copy link

zdQAQ commented Jul 8, 2020

@Thieum still exist. v 22.2.0

@jmorrelles
Copy link

I'm having this problem with 2.0.1. I get the "Couldn't run Squirrel hook" in the log. I have found that when I run setup.exe a second time that the shortcuts are created. That may be a clue to why it fails on the first run if something isn't in place during the first execution, but exists where expected or needed on the second execution.

@benjaffe
Copy link

benjaffe commented Mar 26, 2021

After trying for a while to figure out why --squirrel-install isn't being called for me, I got it to work by creating shortcuts and registry entries on --squirrel-firstrun. I haven't noticed any issues with doing this, but searching around, I haven't found anyone else who is doing this.

If anyone knows why I shouldn't be making shortcuts on --squirrel-firstrun, please let me know and save me from myself 😬 🙃 .

(Launching my app manually with --squirrel-install creates shortcuts, but the installer doesn't launch it with that flag. It does launch my app with --squirrel-firstrun though, which is why I'm hooking into that as a last resort).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants