Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing, maintaining, or simplifying the tiled and ldtk examples. #554

Open
rparrett opened this issue Aug 15, 2024 · 1 comment

Comments

@rparrett
Copy link
Collaborator

rparrett commented Aug 15, 2024

Motivated by these PRs:

#530 Seems to fixes a real issue, but would need some work before merging (imo).
#525 Pretty sure that I looked at this once and it may have been fixing a real issue
#501 Seems to possibly do something useful, but needs work. Linked issue was vetoed, though.
#429 Adds support for tsx format, vetoed.
#405 Adds support for particular tile layouts, abandoned

Opening this so we can decide on the record what we want to do with these things and take appropriate actions in the linked PRs and not leave them in limbo forever. I am personally fine with removing them or instituting a "feature freeze" policy, with a slight preference for removing them.

@ChristopherBiscardi
Copy link
Collaborator

The current state is "feature freeze" afaik, so currently those issues contributing to ldtk/tiled examples would be closed as this crate isn't intended to become a tiled/ldtk integration but rather the base layer an integration could be built on top of (like bevy_ecs_tiled/ldtk). The Tiled/LDtk examples (to my knowledge) are meant to be proof-of-concept and used as runnable tests rather than full implementations.

re: removal, the only concern I have is really whether or not there are any similar examples/functionality. I don't think there is; bevy_ecs_ldtk/tiled are large projects that don't really showcase "how to integrate" and asset loading (.ldtk/.tmx) is a pretty unknown quantity for the general bevy population IMO, which tends to make simple integration examples useful I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants