Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: pre-commit support #79

Open
1 task done
Kraust opened this issue Jun 27, 2024 · 1 comment
Open
1 task done

feature: pre-commit support #79

Kraust opened this issue Jun 27, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Kraust
Copy link

Kraust commented Jun 27, 2024

Did you check the docs?

  • I have read all the docs

Is your feature request related to a problem? Please describe.

https://pre-commit.com/

AFAIK pre-commit is commonly used in workflows these days, and I include it in mine. Currently fugit2 doesn't ave great support for it. I don't know if libgit2 has proper support for the hooks that pre-commit creates.

Describe the solution you'd like

I'd like the pre-commit hooks to be run on commit (like git commit does) and some kind of indication to the user if the hook fails fails.

Describe alternatives you've considered

This is not a show stopper preventing me from using fugit2. I can just invoke pre-commit manually as part of my workflow (and my CI/CD also runs it).

Additional context

No response

@Kraust Kraust added the enhancement New feature or request label Jun 27, 2024
@SuperBo
Copy link
Owner

SuperBo commented Jun 28, 2024

Hi @Kraust, pre-commit is not implemented in libgit2 libgit2/libgit2#964. It is the responsibility of IDE/plugin to implement it. In this case, Fugit2 have to handle and call pre-commit command explicitly.

Let's me investigate how to implement it. It may take a while because I'm not so familiar with pre-commit yet.

As always, Thank you for great suggestion! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants