Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about how to log database queries to the LOCAL_DEVELOPMENT.md #1903

Closed
daveverwer opened this issue Jul 18, 2022 · 3 comments · Fixed by #1912
Closed

Add a note about how to log database queries to the LOCAL_DEVELOPMENT.md #1903

daveverwer opened this issue Jul 18, 2022 · 3 comments · Fixed by #1912

Comments

@daveverwer
Copy link
Member

Instructions are in #1896

@heckj
Copy link
Sponsor Collaborator

heckj commented Jul 19, 2022

setting to .info was an eye opener, and unexpected!

The docs referenced from Logger.level indicate the levels are ordered in terms of criticality, but then have descriptions that make me think they're not entirely in an expected order in the DocC generated content, which is immensely confusing. Instead, I think they're just dropped in alphabetically by DocC. I'll make a mention of this upstream in Logger, as that was the most surprising to me. I misread things and thought .debug was more messages and less focused than .info, but it's (apparently) the other way around.

@heckj
Copy link
Sponsor Collaborator

heckj commented Jul 19, 2022

Logged the fact that it's grossly unordered in DocC upstream: apple/swift-log#224 (and submitted a PR upstream to help resolve: apple/swift-log#225)

@samdeane
Copy link
Collaborator

samdeane commented Jul 20, 2022

I had the same confusion @heckj. I read the instructions, and thought “info must be a typo, I probably need to set it to debug to get the extra logging”, then looked at the code and went “huh?”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants