Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] custom playback speed #115

Closed
bitingsock opened this issue Oct 6, 2016 · 5 comments
Closed

[Feature request] custom playback speed #115

bitingsock opened this issue Oct 6, 2016 · 5 comments

Comments

@bitingsock
Copy link

Usually when my group of friends watch movies we watch at 1.1-1.2X speed. This feature would be very desirable for us for syncplay to support. It seems that if everyone sets the speed at the same time it keeps us sync until it seeking or pausing resets it; but have a synced setting would be best.

@Et0h
Copy link
Contributor

Et0h commented Oct 6, 2016

I can see why it'd be useful, but it'd probably need a third-party to adopt this as a project for it to get done.

http://syncplay.pl/guide/trouble/ notes that: "Manually setting the playback rate may cause problems. Syncplay generally assumes a playback rate of 1.0 and in some instances sets the playback rate to help get everyone more in sync."

Not sure how much work it would take for the clients and servers to support varying playback speeds, but it'd certainly be non-trivial.

@winneon
Copy link

winneon commented Dec 6, 2016

I know that MPC-HC and VLC both support playback speeds in their own form, and they act the same. I'm currently learning mpv as my main player, so I do not know if mpv supports the same thing, but if mpv and mplayer supports the same concept, it shouldn't be difficult to implement this, correct? Of course, this is assuming each player has direct API access to control the playback speed in conjunction with the other features Syncplay provides.

@Et0h
Copy link
Contributor

Et0h commented Dec 6, 2016

mpv supports playback rate changes, but that isn't the issue. The Syncplay client/server both assume things move forwards 1 second per second and that is an assumption made at various points in the code (e.g. using the difference in seconds to calculate current position if the player hasn't responded recently), so in addition to the protocol changes there would need to be some algorithm changes too (plus code to monitor speed to detect changes). Furthermore, if one wanted the 'slowdown on desync' feature at the same time as playback-syncing one has to be able to distinguish between them and potentially apply one to the other... eep!

@daniel-123
Copy link
Contributor

@winneon I agree with other guys about this being a feature not really being worthwhile - it would take considerable effort to properly implement and vast majority of users would never use it. On the other hand Syncplay already can kinda support the feature if setup in particular way:

  • "Fast-forward if lagging behind" option in Sync tab turned off on all clients
  • All clients have exactly the same playback rate - as long as it isn't something crazy high/low. It can be for example passed as player argument (--speed=1.2 in mpv for example).

I have tested it only with mpv, which is by far most robust out of supported players. Dunno whether others will work.

@Et0h
Copy link
Contributor

Et0h commented Jan 30, 2017

Have added it as an idea at http://syncplay.pl/about/ideas/ and anyone is free to implement it. If it were implemented, it would need to be done properly so it would work on a per-room basis and give a warning if someone has a client/player that doesn't support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants