Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential split-package issue #261

Closed
remal opened this issue Nov 11, 2019 · 2 comments
Closed

Potential split-package issue #261

remal opened this issue Nov 11, 2019 · 2 comments

Comments

@remal
Copy link

remal commented Nov 11, 2019

I'm using ArchUnit JUnit5 and, as I can see, it has a potential split-package issue - both archunit-junit5-api and archunit-junit5-engine artifacts have classes inside com.tngtech.archunit.junit.

But JPMS doesn't allow different modules to have classes in the same package.

Potentially this will cause some issues with running ArchUnit on JVM 9+.

@codecholeric
Copy link
Collaborator

Yes, I'm aware of that ☹️ I didn't want to break the API so far, because nobody has reported an actual issue (so far always just a potential one), but I think we should fix it. Maybe when we release 1.0 it would be a good time to do this.
Actually moving the engine shouldn't cause any breakages, since no user should depend on those classes.
Historically the reason it is as it is, is because archunit-junit4 and archunit-junit5* share a lot of code from package com.tngtech.archunit.junit, so it seemed easiest to add everything to the same package, also enabling package visibility for classes that should not be exposed.
I'll look into it, maybe I can do something with the Shadow plugin, simply relocating some files in archunit-junit5-engine, we'll see...

@codecholeric
Copy link
Collaborator

Closing this in favor of #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants