Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only the 404 error page from TYPO3 is applicable #281

Open
boneyfantaseas opened this issue Nov 9, 2022 · 1 comment
Open

Only the 404 error page from TYPO3 is applicable #281

boneyfantaseas opened this issue Nov 9, 2022 · 1 comment
Labels
v1 Version 1.x

Comments

@boneyfantaseas
Copy link

error.response.status === 404 &&

According to this line we can only use the 404 error page from within TYPO3. Is there a reason to do so? I suggest changing this line to

error.response.status >= 400 &&

in order to be able to maintain all error codes in TYPO3.

@boneyfantaseas boneyfantaseas changed the title Only the 404 error page from TYPO3 is applied Only the 404 error page from TYPO3 is applicable Nov 9, 2022
@mercs600
Copy link
Contributor

@boneyfantaseas yes, it was intended only for 404 and initialData fallback, but is ok to handle more error codes there. PR is welcome.
You can also attach your own error interceptor on $typo3.api.$http object

@mercs600 mercs600 added the v1 Version 1.x label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1 Version 1.x
Projects
None yet
Development

No branches or pull requests

2 participants