Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve css standard discrepancy between mapbox-gl-rails 2.9.0 and sassc-ruby #792

Closed
rudokemper opened this issue Aug 15, 2022 · 0 comments
Labels
atalm ruby Pull requests that update Ruby code

Comments

@rudokemper
Copy link
Member

The latest 2.9.0 version of Mapbox GL Rails allows us to implement some of Mapbox's latest features, including the new globe projection. However recent changes in this codebase to the CSS formatting - specifically, a rgb(x x x / x%) standard - causes the gem to break with SCSS because of this issue which happens because SASS is not yet supporting this standard.

image

Since sassc-ruby is not being maintained at the moment, we need to figure out how to resolve this issue before bumping the Mapbox GL Rails gem to 2.9.0.

With the refactor, we are moving away from Administrate, but are we otherwise reliant on SASS that will cause issues? Or do we need to move to another library like sass-embedded or use one of the stop gap solutions described here?

👀 @lauramosher

@rudokemper rudokemper added the ruby Pull requests that update Ruby code label Aug 15, 2022
@rudokemper rudokemper added Hacktoberfest Hacktoberfest 2023 atalm and removed Hacktoberfest Hacktoberfest 2023 labels Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atalm ruby Pull requests that update Ruby code
Projects
None yet
Development

No branches or pull requests

1 participant