Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What about adding the CodeFormatterProfile.xml with the code format ? #1050

Closed
dota17 opened this issue Jul 23, 2020 · 2 comments · Fixed by #1060
Closed

What about adding the CodeFormatterProfile.xml with the code format ? #1050

dota17 opened this issue Jul 23, 2020 · 2 comments · Fixed by #1060
Labels
Discussion Refactor
Milestone
Release 1.5.2

Comments

@dota17
Copy link
Contributor

dota17 commented Jul 23, 2020 •
edited
Loading

Current code format is unfriendly, such as using tabs for indentation. What is more, not all existing code follow the current code format.
@PhilipRoman
@dota17
Copy link
Contributor Author

dota17 commented Jul 23, 2020 •
edited
Loading

How about replace it with Google or Apache Version?
Some changes :

  1. Update the file CodeFormatterProfile.xml
  2. All code will be changed to follow the new code format.

@dota17 dota17 mentioned this issue Aug 13, 2020
Merged
5 tasks
@marci4 marci4 added this to the Release 1.5.2 milestone Aug 15, 2020
@marci4
Copy link
Collaborator

marci4 commented Aug 15, 2020

I am fine with both formats. Lets do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Refactor
Projects
None yet
Milestone
Release 1.5.2
Development

Successfully merging a pull request may close this issue.

Using Google Java Code Style To Reformat Code dota17/Java-WebSocket
2 participants
@marci4 @dota17