Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: Why is the title not updated on subsequent page loads? #124

Open
tp opened this issue Mar 20, 2015 · 0 comments
Open

Q: Why is the title not updated on subsequent page loads? #124

tp opened this issue Mar 20, 2015 · 0 comments

Comments

@tp
Copy link

tp commented Mar 20, 2015

While I guess there are better ways to observe a changing title (KVO on the UIWebView), I was wondering why you explicitly disregard title changes after the initial load?

See:

if (self.navigationItem.title == nil) {

Would you be interested in a PR which removes that above line and uses KVO to get all title updates (for example from JS) (untested, but I think this should work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant