From c21693b39dfc428bc8a25a6bd7e47be7e34fdb21 Mon Sep 17 00:00:00 2001 From: Sam Roberts Date: Thu, 2 May 2019 09:03:53 -0700 Subject: [PATCH] src: remove node_options-inl.h from header files Fix unnecessary inclusion of node_options-inl.h into env.h via inspector_agent.h, causing almost all of src/ to recompile on any change to the options parser. Its intended that *-inl.h header files are only included into the src files that call the inline methods. PR-URL: https://github.com/nodejs/node/pull/27538 Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Rich Trott Reviewed-By: Anna Henningsen --- src/inspector_agent.cc | 1 + src/inspector_agent.h | 2 +- src/node_worker.cc | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index 78af5508d0780b..fce174012f7a71 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -9,6 +9,7 @@ #include "node/inspector/protocol/Protocol.h" #include "node_errors.h" #include "node_internals.h" +#include "node_options-inl.h" #include "node_process.h" #include "node_url.h" #include "v8-inspector.h" diff --git a/src/inspector_agent.h b/src/inspector_agent.h index c7c92186d114a3..1c2bde0da73e84 100644 --- a/src/inspector_agent.h +++ b/src/inspector_agent.h @@ -6,7 +6,7 @@ #error("This header can only be used when inspector is enabled") #endif -#include "node_options-inl.h" +#include "node_options.h" #include "v8.h" #include diff --git a/src/node_worker.cc b/src/node_worker.cc index c1a1123ef1399e..f9b675e96ad1f1 100644 --- a/src/node_worker.cc +++ b/src/node_worker.cc @@ -2,6 +2,7 @@ #include "debug_utils.h" #include "node_errors.h" #include "node_buffer.h" +#include "node_options-inl.h" #include "node_perf.h" #include "util.h" #include "async_wrap-inl.h"