Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Looks like that adding normalize.css to several apps causes build problems #903

Open
ferrannp opened this issue Apr 4, 2017 · 5 comments
Labels

Comments

@ferrannp
Copy link
Contributor

ferrannp commented Apr 4, 2017

We experienced that internally. Regardless of if we should add normalize.css to Gluestick or not (in my opinion no), we need to find out why is this causing problems.

@ferrannp ferrannp added the bug label Apr 4, 2017
@toddw
Copy link
Contributor

toddw commented Apr 4, 2017

Agreed! We don't need to include normalize.css but we do need to resolve the issue

@zamotany
Copy link
Contributor

zamotany commented Apr 5, 2017

I don't think it's the issue with compiled alias - I've builded and run server with alias (otherwise it would crash) in production, removed compiled from normalize.css imports and builded client and the issue is still present.

@zamotany
Copy link
Contributor

zamotany commented Apr 5, 2017

I believe the best way to go is to try to reproduce it with bare webpack.config.js and w/o gluestick.

Update: can't reproduce the issue with 2 apps with gluestick

@zamotany zamotany self-assigned this Apr 5, 2017
@supergibbs
Copy link
Contributor

Maybe a different issue but I removed normalize.css from my app because I am using Bootstrap4 and it has its own css reset but when I updated gluestick it re-added normalize.css because it thinks it's required even though I am not using it.

@zamotany
Copy link
Contributor

The default project template usues normalize.css, so it's in package.json template. When you run auto-upgrade it will compare your package.json and template's one then prompt to install missing dependencies or update them. That's why you will have normalize.css added as a dependency.

@zamotany zamotany removed their assignment Jan 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants