-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[React-Native] triggers uuid crash when feature with impression data enabled is used with isEnabled
#87
Comments
Hey, thank you for bringing this to our attention. I will raise the issue with the team. |
Hi @Kei-Neurio thanks for opening this issue and providing detailed information. From our tests reproducing the bug it seems like this may not be name-related, but instead impression-data-related. We had no issues with Can you please confirm this? This can be easily changed in Unleash by going to the specific Feature Toggle > Settings > Feature information (edit) > Enable impression data toggle. Easiest way to fix this for end-users would be to install and add My suggestion, however, would be to have a specific Here's a quick PoC: proxy-client-react-native I'll check with the rest of the team on the best way forward regarding this and will let you know 🙂 |
Thank you for the quick response and diagnosis @nunogois! I'll check the impression data toggle and post the result here. Just checked proxy-client-react-native and it's an exciting addition to the project. Looking forward to the update! [update] Yes you are right, it was caused because we had the impression toggle on👍 I'll leave this issue until some fix goes in place but feel free to close it if you wanted! |
isEnabled
isEnabled
Hey @Kei-Neurio - Thanks for confirming this! We'll close this issue for now, but please feel free to reach out to us at anytime 🙂 |
Describe the bug
Hi! It's a really specific issue. when a certain word is used for key and run
isEnabled()
with it, it causes a crash bug which is coming from uuid library. I know that it's a known issue with v4 uuid and there's a monkey patch fix for it, but I figured it's confusing for ones who are not familiar/new to React Native. I have no idea why that particular word triggers this behavior... but I hope this report helps someone come across the same issue. I fixed it by changing the word topwd
but I have a feeling that there are more keywords that triggers this issue.The straightforward fix for this issue would be installing react-native-get-random-values but it doesn't feel right to bring it only for React Native since this library is for other frameworks too.
dependencies:
Steps to reproduce the bug
isEnabled()
function with the key just createdExpected behavior
isEnabled()
should returntrue
value.Logs, error output, etc.
No response
Screenshots
Additional context
No response
Unleash version
1.11.0
Subscription type
Enterprise
Hosting type
No response
SDK information (language and version)
No response
The text was updated successfully, but these errors were encountered: