Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machete file edit - unable to insert white characters #1598

Open
mkondratek opened this issue Mar 4, 2023 · 4 comments
Open

Machete file edit - unable to insert white characters #1598

mkondratek opened this issue Mar 4, 2023 · 4 comments

Comments

@mkondratek
Copy link
Collaborator

mkondratek commented Mar 4, 2023

Bug description

  1. Checkout a branch that does not exist in the machete file
  2. Open machete file
  3. Try to insert the branch's entry below some other branch (e.g. develop, at least one level indent)

Actual:
Carriage returns immediately to the beginning of the line once a white character is inserted

Expected:
Carriage remains in place; user can insert an entry at any indention level

WORKAROUND:
write the entry name first; move it later

@PawelLipski
Copy link
Collaborator

Huh I can't reproduce 👶🏻 could you attach a screen recording? 🎥

@mkondratek
Copy link
Collaborator Author

Screen.Recording.2023-03-06.at.09.56.19.mov

The backgroundable task appearing for a in the split second is Updating Git Machete status...

@PawelLipski
Copy link
Collaborator

Huh weird... I'm seeing this Updating Git Machete status... when trying to repro, but trailing whitespace isn't removed.
It would be nice to check if com.virtuslab.gitmachete.frontend.file.MacheteFileWriter#writeBranchLayout is being called and what's the stacktrace of this call if so

@PawelLipski PawelLipski changed the title Machete file edition - unable to insert white characters Machete file edit - unable to insert white characters Mar 11, 2023
@PawelLipski
Copy link
Collaborator

PawelLipski commented Mar 11, 2023

(btw edition doesn't mean the act of editing, i.e. PL edycja; it means PL nakład, wydanie)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants