Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] NPM prepare script fails on windows #611

Open
Hypersycos opened this issue Aug 22, 2024 · 1 comment
Open

[Bug] NPM prepare script fails on windows #611

Hypersycos opened this issue Aug 22, 2024 · 1 comment
Labels
help wanted Extra attention is needed Scope: Out of Scope Not provided by DE's API Severity4: Inconvenient The defect does not affect functionality or critical data. It is merely an inconvenience. Type: Bug

Comments

@Hypersycos
Copy link

Describe the bug

NPM prepare script fails on windows

NodeJS Version

20.12.2

npm Version

10.5.0

warframe-items Version

1.1262.114

Access Method

npm Package (Default)

What happened?

The current prepare script
npx install-peerdeps @wfcd/eslint-config@latest -S
in package.json fails on windows with the error
err spawn einval

It can be bypassed by installing with scripts disabled and then manually installing the es-lint config. I believe it's something to do with this security patch, but I couldn't figure out how to pass the parameter.

This issue is shared with warframe-relic-data, and likely all other projects using the eslint-config, though I haven't checked.

@Hypersycos Hypersycos added help wanted Extra attention is needed Scope: Out of Scope Not provided by DE's API Severity4: Inconvenient The defect does not affect functionality or critical data. It is merely an inconvenience. Type: Bug labels Aug 22, 2024
@TobiTenno
Copy link
Member

yes, it's caused by nathanhleung/install-peerdeps#125

given that our CI is on not-Windows, and this doesn't fail in WSL, i'd recommend using WSL (generally i recommend using it over barebacking windows anyway)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Scope: Out of Scope Not provided by DE's API Severity4: Inconvenient The defect does not affect functionality or critical data. It is merely an inconvenience. Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants