Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make INN logo options configurable by sites using the Customizer. #1529

Open
5 tasks
benlk opened this issue Sep 10, 2018 · 2 comments
Open
5 tasks

Make INN logo options configurable by sites using the Customizer. #1529

benlk opened this issue Sep 10, 2018 · 2 comments
Labels
category: feature add New/added features Estimate: < 4 Hours hacktoberfest help wanted priority: normal Must be completed before release of this version of plugin. status: needs docs type: improvement
Milestone
0.7 - Foundation ...

Comments

@benlk
Copy link
Collaborator

benlk commented Sep 10, 2018 •
edited
Loading

We currently ship the INN logo with light-background and dark-background versions, with the notes seen in img/readme.md: https://github.com/INN/largo/tree/0.5-dev/img/

We should:

  • provide option to enable/disable logo; this is currently handled via a constant in wp-config.php and it should be configurable by end users.
  • provide theme options to switch the logo used
    • inn_logo_blue_final.png (28K)
    • inn_logo_gray.png (4.3K)
    • inn_logo_reversetype.png (28K)
  • provide theme option to switch between the INN logo for members and the INN logo for affiliates

It would be nice if

  • the controls are exposed via the customizer.
  • the logo is an inline SVG instead of externally-loaded PNGs
@benlk benlk added this to the 0.6 - Performance & SEO milestone Sep 10, 2018
@benlk benlk added type: improvement priority: normal Must be completed before release of this version of plugin. status: needs docs labels Sep 10, 2018
@benlk
Copy link
Collaborator Author

benlk commented Sep 10, 2018

Because this function is a pluggable function, child themes that have plugged the function won't be affected by these changes. That's acceptable.

@benlk
Copy link
Collaborator Author

benlk commented Aug 21, 2019

If this is to be implemented in the customizer, this is blocked by #1438.

@benlk benlk changed the title Redo handling of INN logo in footer Make INN logo options configurable by sites using the Customizer. Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: feature add New/added features Estimate: < 4 Hours hacktoberfest help wanted priority: normal Must be completed before release of this version of plugin. status: needs docs type: improvement
Projects
None yet
Milestone
0.7 - Foundation for Customization
Development

No branches or pull requests
1 participant
@benlk