Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Largo's custom post templating engine with WordPress' own page template functions #1847

Open
4 tasks
benlk opened this issue Jan 31, 2020 · 0 comments
Open
4 tasks
Labels
category: sunset things we're sunsetting status: needs review type: tech debt For necessary updates because code is old

Comments

@benlk
Copy link
Collaborator

benlk commented Jan 31, 2020

See all this code in https://github.com/INN/largo/blob/v0.6.4/inc/post-templates.php#L1-L115 ?

That predated the post template engine in WordPress core: https://developer.wordpress.org/themes/template-files-section/page-template-files/

Migration notes in https://make.wordpress.org/core/2016/11/03/post-type-templates-in-4-7/

Some questions that will require research:

  • this template picker is normally only present on Pages; what is needed to make it available for Posts?
    • probably only the addition of the "Template Post Type: post, page" line in the file header
  • what migration functionality is necessary?
  • how will our template partials change?
  • what needs to be done to allow site users to set a default template? Can we perform that change as part of the migration to the Customizer in Migrate Theme Options/Options Framework to Customizer controls #1438?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: sunset things we're sunsetting status: needs review type: tech debt For necessary updates because code is old
Projects
None yet
Development

No branches or pull requests

1 participant