Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate and Delete Custom Favicon Option #835

Open
0aveRyan opened this issue Aug 13, 2015 · 5 comments
Open

Migrate and Delete Custom Favicon Option #835

0aveRyan opened this issue Aug 13, 2015 · 5 comments
Labels
Estimate: < 6 Hours hacktoberfest help wanted priority: normal Must be completed before release of this version of plugin.
Milestone
0.7 - Foundation ...

Comments

@0aveRyan
Copy link

One less custom thing for us to maintain! WordPress 4.3 (dropping mid-late August) adds the Site Icon feature. We probably want to nix Largo's and migrate existing settings.

https://make.wordpress.org/core/2015/07/27/site-icon/
@0aveRyan 0aveRyan added the priority: normal Must be completed before release of this version of plugin. label Aug 13, 2015
@0aveRyan 0aveRyan self-assigned this Aug 13, 2015
@aschweigert
Copy link

what is the UI for that going to look like?

@0aveRyan
Copy link
Author

@aschweigert Customizer is WordPress' intended user flow, of course. It's within the new Identity Panel. But it's just a field we could spit out elsewhere.
screen shot 2015-08-13 at 9 16 10 am

@0aveRyan
Copy link
Author

@aschweigert it's nice bc it does favicon in addition to fancy things like Windows 10 App Icon, iOS bookmark icon, etc.

@benlk
Copy link
Collaborator

benlk commented Aug 22, 2019

Migrate Largo's custom site icon logic to use WordPress' logic.

@benlk benlk mentioned this issue Aug 22, 2019
Open
@benlk
Copy link
Collaborator

benlk commented Mar 19, 2020

See also https://make.wordpress.org/core/2020/02/19/enhancements-to-favicon-handling-in-wordpress-5-4/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Estimate: < 6 Hours hacktoberfest help wanted priority: normal Must be completed before release of this version of plugin.
Projects
None yet
Milestone
0.7 - Foundation for Customization
Development

No branches or pull requests
4 participants
@aschweigert @benlk @rclations @0aveRyan