Skip to content
This repository has been archived by the owner on Feb 11, 2024. It is now read-only.

Add integration tests to cover CORS configuration #59

Open
xav opened this issue Jul 10, 2023 · 1 comment
Open

Add integration tests to cover CORS configuration #59

xav opened this issue Jul 10, 2023 · 1 comment
Labels
area-tests Testing

Comments

@xav
Copy link
Contributor

xav commented Jul 10, 2023

There have been issues with the CORS configuration not working, leading to #57 and eventually simplifying how CORS is handled in the service.
However, these changes are done in blind faith and we have no tests to ensure the CORS headers are correctly served.

We need to add those tests.
@xav
Copy link
Contributor Author

xav commented Jul 10, 2023 

  Can you take a note for when you re-enable the integ tests to cover this there to prevent regressions?

Originally posted by @arein in #58 (review)

@xav xav mentioned this issue Jul 10, 2023
Merged
3 tasks
@xav xav added the area-tests Testing label Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-tests Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xav