Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Network ID to determine the correct faucet to use #2701

Open
mvadari opened this issue May 30, 2024 · 0 comments
Open

Use Network ID to determine the correct faucet to use #2701

mvadari opened this issue May 30, 2024 · 0 comments

Comments

@mvadari
Copy link
Collaborator

mvadari commented May 30, 2024

Code reference: https://github.com/XRPLF/xrpl.js/blob/main/packages/xrpl/src/Wallet/fundWallet.ts

Currently, the faucet generation code guesses the correct faucet to use based on substrings in the URL. This isn't a very robust system. It would be better (and more robust) to use the Network ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant