Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

Clean up JS code / add JS linters to Travis #1077

Closed
orenyk opened this issue Jan 1, 2015 · 3 comments
Closed

Clean up JS code / add JS linters to Travis #1077

orenyk opened this issue Jan 1, 2015 · 3 comments

Comments

@orenyk
Copy link
Contributor

orenyk commented Jan 1, 2015

Offshoot of #1075, we need to clean up our JS code such that it passes our JS linters before we include those linters in Travis. This should probably happen after #1061 #245 since there will likely be significant changes to our JS codebase then.

@mnquintana
Copy link
Contributor

FWIW I don't think we need to wait on #1061 – that will be so much of a rewrite that it's a long ways off. We would really benefit from cleaned up JS now, even if much of it will be rewritten in several months.

I do think we should wait on #245 though, since that will be done a lot sooner.

@orenyk
Copy link
Contributor Author

orenyk commented Jan 1, 2015

Good points, I'll update the description :-).

@orenyk
Copy link
Contributor Author

orenyk commented Jun 10, 2016

Merged into #1581

@orenyk orenyk closed this as completed Jun 10, 2016
@orenyk orenyk modified the milestones: API/client, 6.2.0 Jun 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants