Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

Document USE_LDAP and ignore .env #1104

Closed
2 of 6 tasks
orenyk opened this issue Jan 20, 2015 · 3 comments
Closed
2 of 6 tasks

Document USE_LDAP and ignore .env #1104

orenyk opened this issue Jan 20, 2015 · 3 comments

Comments

@orenyk
Copy link
Contributor

orenyk commented Jan 20, 2015

I realized that I left out the USE_LDAP environment variable when I set up .env.example. We're also tracking the .env file in Git, which isn't really good practice. Therefore, we should do the following:

  • document USE_LDAP in .env.example
  • document USE_LDAP in the configuration wiki page
  • document LDAP stuff in the Heroku wiki page
  • properly ignore .env
  • move USE_LDAP to secrets.yml?
  • move CAS_AUTH to secrets.yml?

The last two point occurred to me as I thought about removing the .env file... to be honest, we shouldn't really need to copy both a secrets.yml file and a .env file to run the app locally. I'm happy to use a Rails secret for both instead of the raw environment variables, any thoughts?

@orenyk orenyk added this to the 5.1.0 milestone Jan 20, 2015
@orenyk orenyk added pri: 3 and removed pri: 5 labels Jan 20, 2015
@orenyk orenyk changed the title Add USE_LDAP to .env.example and ignore .env Document USE_LDAP and ignore .env Jan 20, 2015
@orenyk
Copy link
Contributor Author

orenyk commented Feb 16, 2015

I'm going to merge this into #275 since I still have some cleanup to do there.

@orenyk
Copy link
Contributor Author

orenyk commented Feb 16, 2015

Ok, just finishing up the removal of .env from Git; from now on new users should copy the .env.example file and uncomment the example lines as desired (for LDAP and CAS). Other configuration parameters will be defined in secrets.yml.

@orenyk
Copy link
Contributor Author

orenyk commented Feb 17, 2015

closed via #1103

@orenyk orenyk closed this as completed Feb 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant