Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3.4 #62

Closed
Calinou opened this issue Nov 5, 2021 · 8 comments
Closed

Update to 3.4 #62

Calinou opened this issue Nov 5, 2021 · 8 comments
Labels
RELEASE Tag for new release-related issues

Comments

@Calinou
Copy link
Collaborator

Calinou commented Nov 5, 2021

3.4-stable is tagged on GitHub, which means this Docker image can be updated for Godot 3.4 now. (The announcement post will be made today or tomorrow.)

@Calinou Calinou added the RELEASE Tag for new release-related issues label Nov 5, 2021
@mars3142
Copy link

mars3142 commented Nov 8, 2021

Would it be possible to create a cron job, which build the latest godot-ci without manual doing? That would speed up every new docker container with godot for ci.

@abarichello
Copy link
Owner

The latest releases took longer because I was used to Docker Hub's Autobuild, it got removed from the free plan and now I have to do everything manually.
image
I like the idea of a daily script, it would be a cheaper option as a replacement to automate everything

@abarichello
Copy link
Owner

#65

@davcri
Copy link

davcri commented Nov 14, 2021

I noticed that Mac build is failing with this error

ERROR: Cannot export project with preset "Mac OSX" due to configuration errors:
Invalid bundle identifier: Identifier is missing.

See example 1 and example 2.

I solved it in godot-game-template (diff) by manually specifing the identifier in the export preset. Not sure if something is changed with Godot 3.4.

@OverloadedOrama
Copy link
Contributor

I noticed that Mac build is failing with this error

ERROR: Cannot export project with preset "Mac OSX" due to configuration errors:
Invalid bundle identifier: Identifier is missing.

See example 1 and example 2.

I solved it in godot-game-template (diff) by manually specifing the identifier in the export preset. Not sure if something is changed with Godot 3.4.

This is most likely due to godotengine/godot#49276. Mac projects need to have an identifier in order to be valid. Also keep in mind that only letters, numbers, dashes (-) and dots (.) are allowed. If the identifier has, for example, an underscore (_) it will also give an error during export.

@davcri
Copy link

davcri commented Nov 14, 2021

I noticed that also the Android debug build is now failing as already mentioned in #59:

ERROR: Cannot export project with preset "Android Debug" due to configuration errors:
A valid Android SDK path is required in Editor Settings.

There is a workaround (Dockerfile + Docker Image) here: crystal-bit/godot-game-template#53 (comment)
I don't know if it's a good approach, but I if it's helpful I can open a PR to update godot-ci's Dockerfile!

@Calinou
Copy link
Collaborator Author

Calinou commented Dec 13, 2021

@davcri Android exporting should be fixed in the next image release since #69 was merged.

@Calinou
Copy link
Collaborator Author

Calinou commented Dec 13, 2021

@Calinou Calinou closed this as completed Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RELEASE Tag for new release-related issues
Projects
None yet
Development

No branches or pull requests

5 participants