Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on correct naming for logger types and properties #1640

Open
lawrence-forooghian opened this issue Apr 10, 2023 · 1 comment
Open
Labels
enhancement New feature or improved functionality.
Milestone

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Apr 10, 2023

At the moment, we have an existing type ARTLog, which is set as the ARTClientOptions’s logHandler property (whose naming comes from the feature spec). And then internally in the codebase it's often assigned to a logger property.

So, a couple of things:

  1. What is the correct class / type name? *Log or *Logger or *LogHandler?
  2. Once we decide that, then align the property names to match.

(Created from #1616 (comment))

┆Issue is synchronized with this Jira Task by Unito

@sync-by-unito
Copy link

sync-by-unito bot commented Apr 10, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3520

@umair-ably umair-ably added the enhancement New feature or improved functionality. label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

No branches or pull requests

2 participants