Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit usage of readwrite in property declarations #1646

Open
lawrence-forooghian opened this issue Apr 12, 2023 · 1 comment
Open

Audit usage of readwrite in property declarations #1646

lawrence-forooghian opened this issue Apr 12, 2023 · 1 comment
Labels
code-quality Affects the developer experience when working in our codebase.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Apr 12, 2023 •
edited by sync-by-unito bot
Loading

We only need to write readwrite if we're refining a declaration of a property already declared. Else readwrite should be removed.

┆Issue is synchronized with this Jira Task by Unito
@lawrence-forooghian lawrence-forooghian added the code-quality Affects the developer experience when working in our codebase. label Apr 12, 2023
@sync-by-unito
Copy link

sync-by-unito bot commented Apr 12, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Affects the developer experience when working in our codebase.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lawrence-forooghian