Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a way to link public API invocations to their eventual outputs #1658

Open
lawrence-forooghian opened this issue Apr 13, 2023 · 1 comment
Labels
enhancement New feature or improved functionality.
Milestone

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Apr 13, 2023

Background

In #1655 we added log statements which are emitted whenever a public API method is invoked.

Many of these method invocations will eventually provide some sort of output to the caller, namely:

  • they will return a value (and possibly also pass an error via an NSError ** argument), or
  • they will invoke a callback

In #1656 and #1657 we will want to log these outputs. As part of doing so, we would like to identity the specific method invocation that these log outputs relate to, so that a reader of the logs can match this message up to the log message that was emitted when the method was called.

Logging API considerations (falls under #1617)

We could update the ARTLogPublicAPICall macro suggested in #1655 so that it returns some sort of unique identifier (a UUID, probably) for that specific invocation of the method, and so that it also logs this identifier. Then, in #1656 and #1657, we will include this identifier as part of the log messages that are emitted when a value is returned or a callback invoked.

Depends on

┆Issue is synchronized with this Jira Task by Unito

@lawrence-forooghian lawrence-forooghian added this to the Logging milestone Apr 13, 2023
@sync-by-unito
Copy link

sync-by-unito bot commented Apr 13, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3532

@lawrence-forooghian lawrence-forooghian changed the title Create a way to link public API calls to their eventual outputs Create a way to link public API invocations to their eventual outputs Apr 13, 2023
@umair-ably umair-ably added the enhancement New feature or improved functionality. label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

No branches or pull requests

2 participants