Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Republish messages that were canceled after connection suspension #106

Closed
ikbalkaya opened this issue Mar 1, 2023 · 1 comment · Fixed by #107
Closed

Republish messages that were canceled after connection suspension #106

ikbalkaya opened this issue Mar 1, 2023 · 1 comment · Fixed by #107
Assignees
@ikbalkaya
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@ikbalkaya
Copy link
Contributor

ikbalkaya commented Mar 1, 2023 •
edited
Loading

Connection suspension will cause queued messages (if any) to fail.

Upon connection resume we need to resend those canceled messages (before any other subsequent messages) to maintain continuity of published messages.

For this, create an intermediary queue and add missing sink records so that they can be resent when connection is re-established. Make sure the order of publishes do not change
@ikbalkaya ikbalkaya added the bug Something isn't working. It's clear that this does need to be fixed. label Mar 1, 2023
@sync-by-unito
Copy link

sync-by-unito bot commented Mar 1, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3441

@ikbalkaya ikbalkaya mentioned this issue Mar 3, 2023
Merged
@sync-by-unito sync-by-unito bot assigned owenpearson and ikbalkaya and unassigned ikbalkaya and owenpearson Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikbalkaya ikbalkaya

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add suspend queue ably/kafka-connect-ably
2 participants
@ikbalkaya @owenpearson