Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove orphaned config #135

Closed
jaley opened this issue Jun 22, 2023 · 2 comments · Fixed by #139
Closed

Remove orphaned config #135

jaley opened this issue Jun 22, 2023 · 2 comments · Fixed by #139
Milestone
V3 - Ably Batch P...

Comments

@jaley
Copy link
Contributor

jaley commented Jun 22, 2023

Moving to the REST Batch API for publishing means we no-longer support some features and can remove the associated config. For example:

  • Cipher key to Realtime connection encryption
  • Various host/port overrides to point connector at alternative realtime endpoints for testing
  • Client message queuing (?)
  • Realtime auto-connect
  • Realtime-related timeouts
  • Channel attachment related config
  • ...

@mattheworiordan or @paddybyers - I might need one of you to take a quick look over ChannelSinkConnectorConfig to help identify things that need to be removed with the removal of the Realtime connection.
@jaley jaley added this to the V3 - Ably Batch Publishing milestone Jun 22, 2023
@sync-by-unito
Copy link

sync-by-unito bot commented Jun 22, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3696

@jaley jaley mentioned this issue Jun 23, 2023
Merged
@jaley jaley linked a pull request Jun 23, 2023 that will close this issue
Remove legacy config and documentation #139
Merged
@jaley
Copy link
Contributor Author

jaley commented Jun 29, 2023

Closed in #139

@jaley jaley closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
V3 - Ably Batch Publishing
Development

Successfully merging a pull request may close this issue.

Remove legacy config and documentation ably/kafka-connect-ably
1 participant
@jaley