From c2cd32468c4d8ba48a4bbba667a87d6263da874e Mon Sep 17 00:00:00 2001 From: Andrew Clark Date: Fri, 3 Mar 2023 18:41:45 -0500 Subject: [PATCH] Codemod tests to waitFor pattern (4/?) (#26299) This converts some of our test suite to use the `waitFor` test pattern, instead of the `expect(Scheduler).toFlushAndYield` pattern. Most of these changes are automated with jscodeshift, with some slight manual cleanup in certain cases. See #26285 for full context. --- .../__tests__/SimpleEventPlugin-test.js | 28 +- .../src/__tests__/ReactHooks-test.internal.js | 146 +-- .../ReactHooksWithNoopRenderer-test.js | 1027 +++++++---------- .../src/__tests__/ReactIncremental-test.js | 420 ++++--- ...tIncrementalErrorHandling-test.internal.js | 300 +++-- .../ReactIncrementalErrorLogging-test.js | 8 +- .../ReactIncrementalErrorReplay-test.js | 8 +- .../ReactIncrementalReflection-test.js | 44 +- .../ReactIncrementalScheduling-test.js | 60 +- .../ReactIncrementalSideEffects-test.js | 174 +-- .../__tests__/ReactIncrementalUpdates-test.js | 122 +- .../__tests__/ReactInterleavedUpdates-test.js | 24 +- .../__tests__/ReactProfiler-test.internal.js | 8 +- 13 files changed, 1095 insertions(+), 1274 deletions(-) diff --git a/packages/react-dom/src/events/plugins/__tests__/SimpleEventPlugin-test.js b/packages/react-dom/src/events/plugins/__tests__/SimpleEventPlugin-test.js index 005ccfc0acd35..ac0096d7251f1 100644 --- a/packages/react-dom/src/events/plugins/__tests__/SimpleEventPlugin-test.js +++ b/packages/react-dom/src/events/plugins/__tests__/SimpleEventPlugin-test.js @@ -18,6 +18,8 @@ describe('SimpleEventPlugin', function () { let onClick; let container; + let assertLog; + let waitForAll; function expectClickThru(element) { element.click(); @@ -43,6 +45,10 @@ describe('SimpleEventPlugin', function () { ReactDOMClient = require('react-dom/client'); Scheduler = require('scheduler'); + const InternalTestUtils = require('internal-test-utils'); + assertLog = InternalTestUtils.assertLog; + waitForAll = InternalTestUtils.waitForAll; + onClick = jest.fn(); }); @@ -222,12 +228,12 @@ describe('SimpleEventPlugin', function () { ReactDOM.render(