diff --git a/CHANGELOG b/CHANGELOG index ee42552eb47..35f96898e04 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -21,6 +21,7 @@ * Cybersource: Add apple_pay with discover. [DustinHaefele] #5213 * MercadoPago: Add idempotency key field [yunnydang] #5229 * Adyen: Update split refund method [yunnydang] #5218 +* Adyen: Remove raw_error_message [almalee24] #5202 == Version 1.137.0 (August 2, 2024) * Unlock dependency on `rexml` to allow fixing a CVE (#5181). diff --git a/lib/active_merchant/billing/gateways/adyen.rb b/lib/active_merchant/billing/gateways/adyen.rb index 39226f2d438..3f2c26d7e39 100644 --- a/lib/active_merchant/billing/gateways/adyen.rb +++ b/lib/active_merchant/billing/gateways/adyen.rb @@ -904,8 +904,6 @@ def message_from(action, response, options = {}) end def authorize_message_from(response, options = {}) - return raw_authorize_error_message(response) if options[:raw_error_message] - if response['refusalReason'] && response['additionalData'] && (response['additionalData']['merchantAdviceCode'] || response['additionalData']['refusalReasonRaw']) "#{response['refusalReason']} | #{response['additionalData']['merchantAdviceCode'] || response['additionalData']['refusalReasonRaw']}" else @@ -913,14 +911,6 @@ def authorize_message_from(response, options = {}) end end - def raw_authorize_error_message(response) - if response['refusalReason'] && response['additionalData'] && response['additionalData']['refusalReasonRaw'] - "#{response['refusalReason']} | #{response['additionalData']['refusalReasonRaw']}" - else - response['refusalReason'] || response['resultCode'] || response['message'] || response['result'] - end - end - def authorization_from(action, parameters, response) return nil if response['pspReference'].nil? diff --git a/test/unit/gateways/adyen_test.rb b/test/unit/gateways/adyen_test.rb index 43628d0827d..07c978d3ee9 100644 --- a/test/unit/gateways/adyen_test.rb +++ b/test/unit/gateways/adyen_test.rb @@ -383,15 +383,6 @@ def test_failed_authorise_mastercard assert_failure response end - def test_failed_authorise_mastercard_raw_error_message - @gateway.expects(:ssl_post).returns(failed_authorize_mastercard_response) - - response = @gateway.send(:commit, 'authorise', {}, { raw_error_message: true }) - - assert_equal 'Refused | 01: Refer to card issuer', response.message - assert_failure response - end - def test_successful_capture @gateway.expects(:ssl_post).returns(successful_capture_response) response = @gateway.capture(@amount, '7914775043909934')