You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I understand, this was requested by #14 and added with 259d03c However, I have a feeling the change should be reverted. Said logic wastes few seconds for invoking additional build. ue4 build isn't meant to bootstap the Engine and building the ShaderCompilerWorker wouldn't solve said issue anyway as Unreal needs more modules to function properly such as CrashReportClient, UnrealFrontend, UnrealLightmass, etc
User is expected to bootstrap Unreal before using ue4 build. If we want to suport bootstraping from ue4cli we should probably make a custom command.
Also, looking through #14 it seems that this case was a problem with OP's environment setup as he was using a custom Engine source. This wasn't a bug with ue4cli and I doubt anyone else would encounter it. Though I might be mistaken.
Cheers!
The text was updated successfully, but these errors were encountered:
So, after thinking about this for a bit longer there are three solutions:
Remove this code entirerly, since it doesn't build all required tools anyway. (super quick and safe)
Extend this code with all required tools: CrashReportClient-LShipping CrashReportClientEditor-Shipping ShaderCompileWorker UnrealLightmass EpicWebHelper-Shipping. This will still require user to provide UE dependencies on its own but Engine will compile in all cases. (will require a little bit of code and testing but will prevent issues similar to #14)
Go even further than 2. and add entirely new option - ue4 bootstrap - make sure that all dependencies are resolved and UE compiles successfully (probably something for ue4cli successor)
Hey @adamrehn ,
When invoking Editor build process, the following logic will always run inside of
buildDescriptor()
call:ue4cli/ue4cli/UnrealManagerBase.py
Lines 369 to 372 in fed71c1
As I understand, this was requested by #14 and added with 259d03c However, I have a feeling the change should be reverted. Said logic wastes few seconds for invoking additional build.
ue4 build
isn't meant to bootstap the Engine and building theShaderCompilerWorker
wouldn't solve said issue anyway as Unreal needs more modules to function properly such asCrashReportClient
,UnrealFrontend
,UnrealLightmass
, etcUser is expected to bootstrap Unreal before using
ue4 build
. If we want to suport bootstraping from ue4cli we should probably make a custom command.Also, looking through #14 it seems that this case was a problem with OP's environment setup as he was using a custom Engine source. This wasn't a bug with ue4cli and I doubt anyone else would encounter it. Though I might be mistaken.
Cheers!
The text was updated successfully, but these errors were encountered: